Bugfix if-feature validate status and in enum or bits as default value notchecked

[fredgan]

No description provided.

[mbj4668]

This doesn't look quite right. I think it would be better to not do this status check here, but instead do it in chk_if_feature.

[mbj4668]

Why do you do this test? It checks if the reference has a prefix, so if it has a prefix you won't do this check.

[mbj4668]

(sorry for the late comment; I wrote it several weeks ago, but just noticed that I forgot to hit "comment")

[fredgan]

Thanks for your review, the reason for the test is to check if-feature status only within the same module (as mentioned in RFC7950#section-7.21.2), but there are some problems with this implementation (just as you said above), I've adjusted it.

[mbj4668]

I think that this is not the right place to do this test - this function parses a string into an enum. In this module it is only used to parse default values, which is why this works. But the function is more generic than that - it isn't called "{parse_default_value", just "{parse". It is also exported which means that it is part of the API.

Instead, I think the right place is in "derive". The check must be different; you need to check if a default statement is present in the TypeS, and if so, find the corresponing enum statement and report an error if it has a if-feature statement.

Ditto for bits.

[fredgan]

I do this test according to the current logic - "Val" which is a default value is used to check whether the default value is defined, I just add a check about the default value without a if-feature statement, so I think this may be the right position.

Follow as your tips, I reread the code about parsing the types of enumeration/bits, then debug it. If this test is placed in "derive" here,

yanger/src/yang_types.erl

Lines 675 to 682 in 8adf023

	enumeration_type_spec_fun({derive, TypeS}, #type{base = builtin}, M, Ctx0) ->
	{Enumstmts, Ctx1} = get_substmts(['enum'], TypeS, Ctx0),
	parse_enums(Enumstmts, stmt_pos(TypeS), M, Ctx1, undefined);
	enumeration_type_spec_fun({derive, TypeS},
	#type{type_spec = #enumeration_type_spec{
	enums = BaseEnums,
	all_enums = AllBaseEnums,
	all_enum_stmts = AllBaseStmts} = TypeSpec},

there is no default statement in "TypeS", it seems no way to get
the default value, of course, I am not sure that I exactly understand what you mean.