cleanup: Remove unused section in alerts_layout
#2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
deleted the
jdl/cleanup/remove-unnecessary-alert-layout-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
No ticket. This is a somewhat overdue follow-up to #2732 and #2737, which added what is now the commuter rail alerts live view, thus causing
AlertControllerto never be invoked with@id=commuter_rail.Implementation
Screenshots
☝️ is both the before and after, because the code that's deleted isn't actually used when rendering this.
How to test
Navigate to the Commuter Rail alerts page and note that the page still loads exactly as it did before.