Skip to content

feat(ingestion): Add automaticStartTime and automaticEndTime to Glides trip updates#748

Merged
runkelcorey merged 3 commits into
mainfrom
feature-ingestion-add-glides-fields
May 14, 2026
Merged

feat(ingestion): Add automaticStartTime and automaticEndTime to Glides trip updates#748
runkelcorey merged 3 commits into
mainfrom
feature-ingestion-add-glides-fields

Conversation

@runkelcorey

Copy link
Copy Markdown
Collaborator

Asana Task: 🚋 add automaticStartTime/EndTime to Glides TripUpdates

What changes does this PR propose?

Adds 2 new fields following mbta/schemas#19 and https://github.com/mbta/glides/pull/3319.

How were these changes validated?

  1. Ran Glides ingestion locally using ctd-glides-prod, saw 0 errors

What questions should reviewers consider?

  1. Should the Tableau runner transform this field out of a string format? We could transform to an Interval

@runkelcorey runkelcorey requested a review from a team as a code owner May 13, 2026 19:35
@runkelcorey runkelcorey requested a review from huangh May 13, 2026 19:35
@runkelcorey runkelcorey added enhancement New feature or request tableau labels May 13, 2026
@runkelcorey runkelcorey assigned runkelcorey and cho-jos and unassigned cho-jos May 13, 2026
@runkelcorey runkelcorey requested review from cho-jos and removed request for a team May 13, 2026 19:36
@github-actions

Copy link
Copy Markdown

LCOV of commit a84ef76 during Continuous Integration (Python) #1918

Summary coverage rate:
  lines......: 64.6% (3512 of 5438 lines)
  functions..: 29.6% (268 of 904 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/glides.py                                                    |95.6%    181|45.5%    44|    -      0

Comment thread src/lamp_py/ingestion/glides.py Outdated
@github-actions

Copy link
Copy Markdown

LCOV of commit c56fcaa during Continuous Integration (Python) #1923

Summary coverage rate:
  lines......: 64.2% (3525 of 5487 lines)
  functions..: 29.6% (269 of 908 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/glides.py                                                    |95.6%    182|45.5%    44|    -      0

@runkelcorey runkelcorey merged commit 1ef3d50 into main May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tableau

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants