feat(ingestion): allow cause_detail and effect_detail to be Translations#765
Merged
Conversation
LCOV of commit
|
huangh
reviewed
Jun 19, 2026
huangh
left a comment
Collaborator
There was a problem hiding this comment.
looks reasonable - decide if any of my comments are valid or if you can live with it - i think the only consequential change would be to further flatten the translation.language out, but if you've already been testing and are okay with the ergonomics of it, it's not a dealbreaker for me.
i could see arguments against doing what i suggested..
LCOV of commit
|
huangh
approved these changes
Jun 22, 2026
huangh
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. last thing non-blocking- should we have some sort of logging when the schema gets expanded or some new input comes in? we want to know that it's happened and perhaps adjust the default schema of record to incude these changes eventually? otherwise our documented dataframely definitions will get outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔔 handle new & old schemas when ingesting alerts
What changes does this PR propose?
Implements temporary logic until Alerts Manager changes schema that
cause_detailandeffect_detailto either be strings orTranslationscause_detail.translationeffect_detail.translationcause_detaileffect_detailNot in scope for this PR is updates to performance manager to actually read the English translations from Alerts in the new schema.
How were these changes validated?
What questions should reviewers consider?