fix(rail): Remove unused import#766
Merged
Merged
Conversation
LCOV of commit
|
huangh
approved these changes
Jun 23, 2026
Collaborator
we would probably want to turn tableau publisher into a long lived ecs task, or alternatively have another tableau-publisher like cron that does all the intermediate conversions, so we can leave tableau publisher as a dumb "publish to tableau" task runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔔 update Performance Manager Alerts feed to expect new data types
What changes does this PR propose?
Technically, this only removes an import that blocked deployment of 77b9494.
Really, this is to create a checkpoint for 77b9494 and 8d5b028. Those commits:
cause_detailandeffect_detailwithcause_detail.translationandeffect_detail.translation, respectively, in Performance ManagerHow were these changes validated?
test_transform_translationsto keep the spirit of its tests but change the test mechanics to allowWhat questions should reviewers consider?