fix(bus): Add plan_stop_departure_dt to headway calculations#767
Merged
Conversation
LCOV of commit
|
Collaborator
|
Did you confirm that all these date times that were tz-less before were all tz-less UTC, and we haven't assigned UTC to EST times? I think there's a test in there somewhere that expects the correct relative difference between time fields, but we should ensure that nothing has changed here. |
Collaborator
Author
yep! |
huangh
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task: 🚌 Add plan_stop_departure_dt to ordering of headways
What changes does this PR propose?
plan_stop_departure_dtto the calculation of headwaysHow were these changes validated?
What questions should reviewers consider?
None.