Skip to content

feat(ingestion): ingest TripProperties.trip_headsign#770

Merged
runkelcorey merged 4 commits into
mainfrom
feat/ingest-trip-headsign
Jun 30, 2026
Merged

feat(ingestion): ingest TripProperties.trip_headsign#770
runkelcorey merged 4 commits into
mainfrom
feat/ingest-trip-headsign

Conversation

@rudiejd

@rudiejd rudiejd commented Jun 29, 2026

Copy link
Copy Markdown
Member

Asana Task: https://app.asana.com/1/15492006741476/project/1189492770004753/task/1215143305292180?focus=true

What changes does this PR propose?

Adds TripUpdate.TripProperties.trip_headsign to LAMP ingestion

How were these changes validated?

Covered by existing tests - I modified the input files to make sure this field is tested.

What questions should reviewers consider?

n/a

@rudiejd rudiejd requested a review from a team as a code owner June 29, 2026 16:47
@rudiejd rudiejd requested a review from runkelcorey June 29, 2026 16:47

trip_properties = dy.Struct(
inner={
"trip_headsign": dy.String(nullable=True)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are more fields in the spec, but this is the only one we populate for now

@huangh

huangh commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@runkelcorey why did the alert test fail? order dependency again?

@github-actions

Copy link
Copy Markdown

LCOV of commit 04571ff during Continuous Integration (Python) #2005

Summary coverage rate:
  lines......: 64.6% (3592 of 5562 lines)
  functions..: 29.9% (275 of 920 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/config_rt_trip.py                                            |82.4%     17|12.5%     8|    -      0
  src/lamp_py/ingestion/gtfs_rt_structs.py                                           | 100%      7|    -     0|    -      0

@rudiejd

rudiejd commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

tests should be good now!

@runkelcorey runkelcorey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I deployed ingestion to dev and saw some records with headsign values!

@runkelcorey runkelcorey merged commit 74fd26c into main Jun 30, 2026
10 checks passed
@runkelcorey runkelcorey deleted the feat/ingest-trip-headsign branch June 30, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants