feat(glides): add revenue field to trip assignment message#17
Merged
rudiejd merged 2 commits intoMar 2, 2026
Merged
Conversation
rudiejd
requested review from
a team,
lemald and
npatel-mbta
and removed request for
a team and
npatel-mbta
lemald
approved these changes
Mar 2, 2026
lemald
left a comment
lemald
left a comment
Member
There was a problem hiding this comment.
I don't love adding more trip metadata to the vehicle trip assignment messages, but I agree that it's probably the best way to solve the issue at hand for now.
Member
Author
|
@lemald yeah, this is a "stop the bleeding" type of change in my view as well. Long term, we should implement TODS and share the same concept of revenue and non-revenue trips department wide. If that ever happens, we can trim this field from the trip assignment message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Ticket: 🔮🐛 Investigate and fix problematic revenue predictions
Adds a revenue field to the
VehicleTripAssignmentmessage from Glides. See https://github.com/mbta/glides/pull/3251 for a description of why this field was necessary.