fix: dereference nested refs#3
Draft
skyqrose wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(blocked, not ready for review)
Asana Task: 🐞 In schemas/ fix dereferencing
As discussed in #2
There's a bug in how we resolve and dereference refs.
This switches to a new library, https://github.com/stoplightio/json-schema-ref-parser , which has resolving and dereferencing that work with sensible defaults, instead of having to define it ourselves.
Unfortunately, that library has a related bug, in that it also doesn't recurse to resolve nested refs if a parent extends a ref.
I filed a bug report stoplightio/json-schema-ref-parser#44 and also a partial fix stoplightio/json-schema-ref-parser#45 , but I didn't manage to fix it all the way.
This PR and bugfix is blocked until that library's maintainers finishes and merges that PR and releases a new version. Alternatively, we could write our own custom resolving and dereferencing, but that seems error prone.
I'm opening this draft PR to document where I am in the bugfix process and to make it easier to resume once the library is updated.