Skip to content

Add angular and time dependence to weight windows#412

Open
nglaser3 wants to merge 7 commits intomcdc-project:devfrom
nglaser3:angle-time-ww
Open

Add angular and time dependence to weight windows#412
nglaser3 wants to merge 7 commits intomcdc-project:devfrom
nglaser3:angle-time-ww

Conversation

@nglaser3
Copy link
Copy Markdown
Member

Summary of changes

This PR adds angle and time dependence to the weight window implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Organization and beautification (changes which improve readability and/or accessibility)

Developer Checklist

  • I have read the contributing guide.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests pass

Associated Issues and PRs

Associated Developers

@nglaser3 nglaser3 self-assigned this Apr 30, 2026
@nglaser3 nglaser3 added the enhancement New feature or request label Apr 30, 2026
@nglaser3 nglaser3 requested review from ilhamv and munkm April 30, 2026 01:03
@ilhamv ilhamv added this to the v0.13.0 milestone May 2, 2026
Comment thread mcdc/object_/technique.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a 3d vector parameter polar_reference, with default value [0.0, 0.0, 1.0]?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, this is supported only in tally. It would be great if we could add support for adjustable polar reference for this WW. Perhaps also in the source as well, later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I am following, is this to generalize the conversion from ux, uy, uz to theta/phi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Angle and time dependence for weight windows

2 participants