Skip to content

Fix unit tests in CI#413

Merged
ilhamv merged 4 commits intomcdc-project:devfrom
nglaser3:fix-unit-test-ci
May 2, 2026
Merged

Fix unit tests in CI#413
ilhamv merged 4 commits intomcdc-project:devfrom
nglaser3:fix-unit-test-ci

Conversation

@nglaser3
Copy link
Copy Markdown
Member

@nglaser3 nglaser3 commented Apr 30, 2026

Summary of changes

This PR aims to fix the unit test workflow in CI which falsely reports success despite tests failing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Organization and beautification (changes which improve readability and/or accessibility)

Developer Checklist

  • I have read the contributing guide.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests pass

Associated Issues and PRs

Associated Developers

@nglaser3 nglaser3 self-assigned this Apr 30, 2026
@nglaser3 nglaser3 added the bug Something isn't working as intended label Apr 30, 2026
@nglaser3
Copy link
Copy Markdown
Member Author

@ilhamv, created this Pr just to make sure the unit tests fail. I will be updating the unit tests to pass in here aswell.

@nglaser3 nglaser3 requested a review from ilhamv April 30, 2026 01:32
@nglaser3
Copy link
Copy Markdown
Member Author

@ilhamv I have updated all of the existing unit tests to now pass, it looks like there were just minor interface changes to some of the methods. I did not expand the unit tests, as I think that belongs in a separate PR.

Copy link
Copy Markdown
Member

@ilhamv ilhamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nglaser3!

@ilhamv ilhamv merged commit b0b3e82 into mcdc-project:dev May 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unit tests fail in CI, but still reported as succesful

2 participants