Fix unit tests in CI#413
Merged
ilhamv merged 4 commits intomcdc-project:devfrom May 2, 2026
Merged
Conversation
Member
Author
|
@ilhamv, created this Pr just to make sure the unit tests fail. I will be updating the unit tests to pass in here aswell. |
Member
Author
|
@ilhamv I have updated all of the existing unit tests to now pass, it looks like there were just minor interface changes to some of the methods. I did not expand the unit tests, as I think that belongs in a separate PR. |
ilhamv
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR aims to fix the unit test workflow in CI which falsely reports success despite tests failing.
Types of changes
Developer Checklist
Associated Issues and PRs
Associated Developers