Skip to content

Only use longest running function as a root when there are no functions w/o parents #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asodeur wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Only use longest running function as a root when there are no functions w/o parents #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions runsnakerun/pstatsloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

def load_pstats(filenames):
"""Given list of filenames, load pstats, potentially using a different python version

Internally will create a python2 subprocess to convert python2
pstats dumps for loading in python3, that will create a cPickle/pickle
dump and load it locally.
Expand Down Expand Up @@ -116,16 +116,21 @@ def find_root(self, rows):
cycles by sorting on cumulative time, and then collecting the traced
roots (or, if they are all on the same root, use that).
"""
maxes = sorted(list(rows.values()), key=lambda x: x.cumulative)
if not maxes:
raise RuntimeError("""Null results!""")
root = maxes[-1]
roots = [root]
roots = []
for key, value in rows.items():
if not value.parents:
log.debug('Found node root: %s', value)
if value not in roots:
roots.append(value)

if len(roots) == 0:
# use longest running function as root when we have not found a root, yet
maxes = sorted(list(rows.values()), key=lambda x: x.cumulative)
if not maxes:
raise RuntimeError("""Null results!""")
root = maxes[-1]
roots.append(root)

if len(roots) > 1:
root = PStatGroup(
directory='*', filename='*', name=_("<profiling run>"), children=roots,
Expand Down