Do not source /* if BASH_COMPLETION_COMPAT_DIR is unset#49
Open
Syphdias wants to merge 1 commit intomchav:masterfrom
Open
Do not source /* if BASH_COMPLETION_COMPAT_DIR is unset#49Syphdias wants to merge 1 commit intomchav:masterfrom
Syphdias wants to merge 1 commit intomchav:masterfrom
Conversation
If BASH_COMPLETION_COMPAT_DIR was unset it tried to source /* wich lead to repl not showing up if there were files in / that lead no termination of sourcing. This could potentially do harm if there is a harmful script in /. $BASH_COMPLETION_DEFAULT_DIR/* will now only be sourced if BASH_COMPLETION_DEFAULT_DIR is set and is not empty.
Author
|
Pinging @dragonator since he original implemented these lines |
Author
|
Example what cause the problem for me: PS: This uses zsh globbing, ignore it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If BASH_COMPLETION_COMPAT_DIR was unset it tried to source /*
wich lead to repl not showing up if there were files in / that
lead no termination of sourcing. This could potentially do harm
if there is a harmful script in /.
$BASH_COMPLETION_DEFAULT_DIR/* will now only be sourced if
BASH_COMPLETION_DEFAULT_DIR is set and is not empty.