Fix issue where FreeRTOS viewer hints are not showing#95
Open
kennedyho-renesas wants to merge 1 commit intomcu-debug:mainfrom
Open
Fix issue where FreeRTOS viewer hints are not showing#95kennedyho-renesas wants to merge 1 commit intomcu-debug:mainfrom
kennedyho-renesas wants to merge 1 commit intomcu-debug:mainfrom
Conversation
- When configUSE_TRACE_FACILITY is 0, uxTCBNumber is not compiled causing it to be undefined. - Make uxTCBNumber optional so it does not cause a TypeError exception, and helpHtml will not be empty.
Collaborator
|
first of all thanks for contributing and directly helping us out here. Can you please state the FreeRTOS version you used for testing? Best regards |
Contributor
Author
|
Thank you for the response. Thanks, and regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue where the hints in FreeRTOS view is not showing at all unless
configUSE_TRACE_FACILITY(macro to enable Thread ID) is set to 1.When
configUSE_TRACE_FACILITYis set to 0,uxTCBNumberis not compiled or linked into the FW, causingthInfo['uxTCBNumber']to beundefined.See: https://github.com/mcu-debug/rtos-views/blob/main/src/rtos/rtos-freertos.ts#L252C17-L252C50
TypeError exception is thrown, jumping to the
catchblock and skipping everything else.htmlHelpremains empty which causes the hints to not be shown.This simple change makes
thInfo['uxTCBNumber']optional so that exception will not be thrown.Simple test result for this change is as follows, where the Thread ID hint is shown as well alongside other missing info: