Skip to content

SES: Correctly interpret element index field when EIIOE=1 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjs-nexsan wants to merge 3 commits into from
Closed

SES: Correctly interpret element index field when EIIOE=1 #276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e52d75
SES: Correctly interpret element index field when EIIOE=1
cjs-nexsan Jun 4, 2026
2ff6b3a
Spaces to tabs
cjs-nexsan Jun 4, 2026
ec9da84
SES: Report additional LED states
cjs-nexsan Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion src/lib/ses.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ static void print_page10(struct ses_pages *sp)
printf("\tDescriptor len (x-1): %d\n", ai[1] + 1);
eip = ai[0] & 0x10;
if (eip)
printf("\tElement Index: %d\n", ai[3]);
printf("\tElement Index: %d EIIOE: %d\n", ai[3], (ai[2] & 0x3));
len = ai[1] + 2;
if ((ai[0] & 0xf) == SCSI_PROTOCOL_SAS) {
if (eip)
Expand Down Expand Up @@ -461,6 +461,7 @@ static void get_led_status(struct ses_pages *sp, int idx, enum led_ibpi_pattern
{
struct ses_slot_ctrl_elem *descriptors = (void *)(sp->page2.buf + 8);
struct ses_slot_ctrl_elem *desc_element = NULL;
element_type ele_type = sp->page1_types[0].element_type;
descriptors++;
desc_element = &descriptors[idx];

Expand All @@ -472,6 +473,43 @@ static void get_led_status(struct ses_pages *sp, int idx, enum led_ibpi_pattern
*led_status = LED_IBPI_PATTERN_LOCATE;
else if (desc_element->b3 & 0x60)
*led_status = LED_IBPI_PATTERN_FAILED_DRIVE;
else if (desc_element->common_control & 0x40)
*led_status = LED_IBPI_PATTERN_PFA;

// Byte 1 is only valid for Array Device Slot elements
if ((*led_status == LED_IBPI_PATTERN_NORMAL) && (ele_type == SES_ARRAY_DEVICE_SLOT))
{
if (desc_element->array_slot_control & 0x04)
*led_status = LED_IBPI_PATTERN_FAILED_ARRAY;
else if (desc_element->array_slot_control & 0x02)
*led_status = LED_IBPI_PATTERN_REBUILD;
else if (desc_element->array_slot_control & 0x20)
*led_status = LED_IBPI_PATTERN_HOTSPARE;
else if (desc_element->array_slot_control & 0x08)
*led_status = LED_IBPI_PATTERN_DEGRADED;
else if (desc_element->array_slot_control & 0x10)
*led_status = LED_SES_REQ_CONS_CHECK;
else if (desc_element->array_slot_control & 0x01)
*led_status = LED_SES_REQ_ABORT;
else if (desc_element->array_slot_control & 0x40)
*led_status = LED_SES_REQ_RSVD_DEV;
}

if (*led_status == LED_IBPI_PATTERN_NORMAL)
{
if (desc_element->b2 & 0x40)
*led_status = LED_SES_REQ_DNR;
else if (desc_element->b2 & 0x08)
*led_status = LED_SES_REQ_INS;
else if (desc_element->b2 & 0x04)
*led_status = LED_SES_REQ_RM;
else if (desc_element->b3 & 0x10)
*led_status = LED_SES_REQ_DEV_OFF;
else if (desc_element->b3 & 0x08)
*led_status = LED_SES_REQ_EN_BA;
else if (desc_element->b3 & 0x04)
*led_status = LED_SES_REQ_EN_BB;
}
}

int ses_get_slots(struct ses_pages *sp, struct ses_slot **out_slots, int *out_slots_count)
Expand Down Expand Up @@ -519,6 +557,13 @@ int ses_get_slots(struct ses_pages *sp, struct ses_slot **out_slots, int *out_sl
((uint64_t)addr_p[19]);

slots[j].index = ap[0] & 0x10 ? ap[3] : j;

// If EIIOE=1, ELEMENT INDEX includes overall elements, otherwise not.
// As (Array) Device Slot elements are always first in the list, there
// will be exactly one overall element that needs to be ignored.
if ((ap[0] & 0x10) && ((ap[2] & 0x3) == 0x01))
slots[j].index--;

get_led_status(sp, slots[j].index, &slots[j].ibpi_status);
}

Expand Down