SES: Correctly interpret element index field when EIIOE=1#278
Open
cjs-nexsan wants to merge 2 commits into
Open
SES: Correctly interpret element index field when EIIOE=1#278cjs-nexsan wants to merge 2 commits into
cjs-nexsan wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
If an SES enclosure reports elements using EIIOE=1 (defined in SES-3), the mapping of SAS devices to slots is offset by 1, causing the incorrect LEDs to be changed.
Cause:
When parsing Additional Element Status descriptors, ledmon does not correctly interpret the SES ELEMENT INDEX field when EIIOE=1; it assumes the SES-2 interpretation where ELEMENT INDEX does not include overall elements. The EIIOE field is defined in SES-3, where an EIIOE=1 indicates that the ELEMENT INDEX field includes overall elements.
Solution:
As the (Array) Device Slot elements are required to be first in the list, there will be exactly one overall element prior to the individual (Array) Device Slot elements, so subtracting one from ELEMENT_INDEX if EIIOE=1 produces the same 0-based individual element index as assumed elsewhere.