mdadm: fix bitmap check#255
Conversation
Commit e97c4e1 ("mdadm: ask user if bitmap is not set") adds a prompt to the user regarding bitmap enabling during creation. However, the case of creating a container, where the bitmap is not meaningful, was omitted. This may mislead the user, as attempting to enable bitmap ends with a container creation error: "mdadm: bitmaps not meaningful with level container" At the stage where this check is performed, the level holds the UnSet value, LEVEL_CONTAINER is set at a later stage in Create. The fix adds a check if the level is UnSet and set bitmap to BitmapNone, because this is the only acceptable value for the container. This check also covers the case when the level is not given during volume creation, as it makes no sense to ask for a bitmap without knowledge about level. Signed-off-by: Blazej Kucman <blazej.kucman@graidtech.com>
| if (s.level == UnSet) | ||
| s.btype = BitmapNone; | ||
| else if (c.runstop != 1 && s.level >= 1 && | ||
| ask("To optimize recovery speed, it is recommended to enable write-intent bitmap, do you want to enable it now?")) |
There was a problem hiding this comment.
As it is part of the "if" condition, I aligned it with the first argument in parentheses.
but I also see that GH cannot display indents correctly.
If there is another better approach to this let me know.
case O(BUILD,'l'): /* set raid level*/
if (s.level != UnSet) {
pr_err("raid level may only be set once. Second value is %s.\n", optarg);
exit(2);
}
s.level = map_name(pers, optarg);
if (s.level == UnSet) {
pr_err("invalid raid level: %s\n",
optarg);
exit(2);Could you please share the scenario it was discovered? is it regular: If you will add --level=container to the command what will happen? Did you considered something like: Just asking, I don't remember exactly the flows. Anyway, I think that discovering container is right way to fix this rather than workarounding the cmdline. |
3 participants
Commit e97c4e1 ("mdadm: ask user if bitmap is not set") adds a prompt to the user regarding bitmap enabling during creation. However, the case of creating a container, where the bitmap is not meaningful, was omitted.
This may mislead the user, as attempting to enable bitmap ends with a container creation error: "mdadm: bitmaps not meaningful with level container"
At the stage where this check is performed, the level holds the UnSet value, LEVEL_CONTAINER is set at a later stage in Create.
The fix adds a check if the level is UnSet and set bitmap to BitmapNone, because this is the only acceptable value for the container. This check also covers the case when the level is not given during volume creation, as it makes no sense to ask for a bitmap without knowledge about level.