imsm: Update VROC branding for new ownership#266
Conversation
bkucman
force-pushed
the
update_imsm_branding
branch
2 times, most recently
from
c0ac229 to
bc8a49e
Compare
|
@mwilck please review :) |
| !imsm_orom_has_tpv_support(super->orom)) { | ||
| pr_err("\tPlatform configuration does not support non-Intel NVMe drives.\n" | ||
| "\tPlease refer to Intel(R) RSTe/VROC user guide.\n"); | ||
| pr_err("\tPlatform configuration does not support non-Intel NVMe drives.\n"); |
There was a problem hiding this comment.
No more documentation for the user to refer to?
There was a problem hiding this comment.
The link to the documentation is already mentioned in the manual. I think code messages should not refer to documentation, as the user is already aware of the product or metadata being used. Otherwise, this line would have to be added to every similar existing message.
|
|
||
| static void print_imsm_capability(const struct orom_entry *entry) | ||
| { | ||
| static const char intel_platform_str[] = " Platform : Intel(R)"; |
There was a problem hiding this comment.
This looks ugly. why combine "Platform" with Intel here, but not with Graid below? I suggest to refactor this to just one line like this:
printf("Platform: %s %s\n", vendor, platform_name)
There was a problem hiding this comment.
Btw, not really a problem of this PR, but from the user PoV, this is highly confusing. Do we need 4 entirely different brand names ("VROC(TM)", "Matrix Storage Manager", "Virtual RAID on CPU", and "Rapid Storage Technology") for essentially the same thing? And what is "Virtual RAID on CPU" supposed to mean?
I tend to dislike this kind of corporate branding games in OSS software.
There was a problem hiding this comment.
I bet this is because GRAID is not a platform owner but software raid provider.
From the other hand we should not touch what already it so I think we have to handle this like that but I do agree that we would just present minor and major version. Unfortunately, in this case it is too late.
There was a problem hiding this comment.
AFAICS this has no technical relevance, it's just text printed to the console. Some users might be slighly confused if we change the output for previously existing hardware, but I doubt that they'll fall in despair over it.
Anyway this is something we should change in a separate PR, if at all. But my first comment still stands.
There was a problem hiding this comment.
I fixed Platform printing, In case of "Rapid Storage Technology" I considered using snprintf, but decided it would be unnecessary complexity, so I simply reused the base name.
I limited printf to platform_name only, because the new name didn’t conform to the "vendor" convention.
This is the branding of a product located on a platform not in Linux itself, and this is very important from the end user's point of view, which product is being used.
This name refers to the product used on the platform (e.g., on the server), and there is a possibility that a newer one will be used in the future, so it is desirable for the name to change accordingly.
It reflects what is currently used in UEFI driver(which reflects what is used on the platform) and the awareness of compatibility and limitations.
VROC is a product that operates across multiple environments (UEFI, Linux, Windows). In theory, this is the same metadata, but with versions the limitations and compatibility with other environments change.
bkucman
force-pushed
the
update_imsm_branding
branch
from
bc8a49e to
2ceb8be
Compare
Update VROC branding for new ownership by Graid Technology Inc. VROC (Virtual RAID on CPU) technology has been acquired by Graid Technology Inc. This patch updates the branding and references to reflect the new ownership while maintaining technical accuracy. The rebranding introduces new versioning starting from version 26. VROC version 9.x and earlier will continue to be displayed as "Intel(R) Virtual RAID on CPU" to accurately reflect their origin. Starting with version 26, the platform is displayed as "VROC(TM) by Graid Technology Inc." Changes include: - Updated maintainer information in README.md from Intel® to Graid Technology Inc. for IMSM metadata format, - Changed documentation URL to point to Graid's VROC documentation, - Updated platform display string to show "VROC(TM) by Graid Technology Inc." for version 26 and later, - Removed Intel branding from VROC-specific error messages. The following references are intentionally preserved: - IMSM metadata format name (Intel(R) Matrix Storage Manager) remains unchanged as it represents the established metadata format, - References to "Intel controller" and "Intel Platform" are maintained where they specifically, refer to Intel hardware components, hardware-specific references remain accurate and unchanged. Signed-off-by: Blazej Kucman <blazej.kucman@graidtech.com>
3 participants
Update VROC branding for new ownership by Graid Technology Inc.
VROC (Virtual RAID on CPU) technology has been acquired by Graid Technology Inc. This patch updates the branding and references to reflect the new ownership while maintaining technical accuracy.
The rebranding introduces new versioning starting from version 26. VROC version 9.x and earlier will continue to be displayed as "Intel(R) Virtual RAID on CPU" to accurately reflect their origin. Starting with version 26, the platform is displayed as "VROC(TM) by Graid Technology Inc."
Changes include:
The following references are intentionally preserved:
V2:
V3: