Declare action runtime as node24 - #315
Merged
Merged
Conversation
GitHub Actions runners already force this action onto Node.js 24 with a deprecation warning, since Node 20 is deprecated - observed in nix-magic-setup#23's smoke test (mdarocha/pondinfra#141) when it was temporarily pinned to main. Declaring node24 removes the warning; no other change needed since the build targets a generic `node` runtime and tsconfig targets ESNext, neither pinned to a specific Node version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016MYz49D9GAahQN6haYW3Nb
mdarocha
pushed a commit
to mdarocha/nix-magic-setup
that referenced
this pull request
Jul 23, 2026
![robo-intern[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Picks up the node24 runtime fix (mdarocha/comment-flake-lock-changelog#315, merged) so the temporary main pin used for testing change-sentinel no longer triggers the Node.js 20 deprecation warning. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016MYz49D9GAahQN6haYW3Nb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub Actions runners already force this action onto Node.js 24 with a deprecation warning, since Node 20 is deprecated:
Observed while smoke-testing nix-magic-setup#23 (which had this action's
mainbranch temporarily pinned) against a real deploy in mdarocha/pondinfra#141.Changes
action.yml:using: node20→using: node24.No other change needed — the build targets a generic
noderuntime (bun build --target=node) andtsconfig.jsontargetsESNext, neither pinned to a specific Node version.🤖 Generated with Claude Code
Generated by Claude Code