Skip to content

Added domree option in order to be able to work with this on shadow dom#178

Open
Agog-io wants to merge 1 commit intomdbassit:mainfrom
Agog-io:domtree-option
Open

Added domree option in order to be able to work with this on shadow dom#178
Agog-io wants to merge 1 commit intomdbassit:mainfrom
Agog-io:domtree-option

Conversation

@Agog-io
Copy link

@Agog-io Agog-io commented Sep 19, 2025

These are the changes I did to make this work on a shadow dom , as i mentioned on #168. I made more tailoring changes for the project I used this in and this is not tested outside that environment

@Agog-io
Copy link
Author

Agog-io commented Sep 19, 2025

This is also tested only with the inline: true option , looking at my implementation.

@Agog-io
Copy link
Author

Agog-io commented Sep 19, 2025

This is exactly my usecase

Coloris({
el: el,//element in shadow dom
parent: parent, ,//element in shadow dom
inline: true,
domTree: shadowDom, // ShadowRoot object
alpha: true,
defaultColor: color,
})

@mdbassit
Copy link
Owner

I can not accept this PR as it will break things. But I will try and use it as a reference to properly support shadowDOM. Thanks for your help!

@Agog-io
Copy link
Author

Agog-io commented Sep 30, 2025

Ofcourse and thats expected, really i just did it asap to integrate it into my project 🫡. Let me know if u need any help or if you encounter any roadblocks , maybe I can point you in the right direction.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments