Added domree option in order to be able to work with this on shadow dom#178
Open
Agog-io wants to merge 1 commit intomdbassit:mainfrom
Open
Added domree option in order to be able to work with this on shadow dom#178Agog-io wants to merge 1 commit intomdbassit:mainfrom
Agog-io wants to merge 1 commit intomdbassit:mainfrom
Conversation
Author
|
This is also tested only with the inline: true option , looking at my implementation. |
Author
|
This is exactly my usecase Coloris({ |
Owner
|
I can not accept this PR as it will break things. But I will try and use it as a reference to properly support shadowDOM. Thanks for your help! |
Author
|
Ofcourse and thats expected, really i just did it asap to integrate it into my project 🫡. Let me know if u need any help or if you encounter any roadblocks , maybe I can point you in the right direction. Good luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes I did to make this work on a shadow dom , as i mentioned on #168. I made more tailoring changes for the project I used this in and this is not tested outside that environment