Move to class system for easier swapping of connectors - #21
Open
Neitsch wants to merge 1 commit into
Open
Conversation
mdezube
reviewed
Feb 17, 2018
mdezube
left a comment
mdezube
left a comment
Owner
There was a problem hiding this comment.
Classes do tend to be better and in general are easier to stub out in tests. I'll try to review this change this weekend, but the other one is pretty much good to go assuming you tested it and it works well.
Contributor
Author
|
I'll do some more testing before moving forward with this :) |
Owner
|
Ha okay, I'll hold off then. Read the blog post though and thoroughly
enjoyed it.
…On Mon, Feb 19, 2018 at 9:38 AM, Nigel Schuster ***@***.***> wrote:
I'll do some more testing before moving forward with this :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACo82nxxAh1HdWcSP7pGeC-zMQU-AWiAks5tWYdVgaJpZM4SHDlB>
.
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd prefer if we use classes for the connectors instead of having stuff in the file scope. This is just an idea :)