fix(outer-layout): avoid summary_large_image in twitter:card
#1227
Conversation
|
4cf74f6 was deployed to: https://fred-pr1227.review.mdn.allizom.net/ |
|
I tested how it looks on X, and unfortunately the image doesn't look good: 
So we would probably want to change it at the same time. |
| "The MDN Web Docs logo, featuring a blue accent color, displayed on a solid black background.", | ||
| "og:site_name": "MDN Web Docs", |
There was a problem hiding this comment.
Might we want to remove references to "MDN Web Docs" here? Perhaps a question for @mdn/content-team
There was a problem hiding this comment.
@LeoMcA are you suggesting we just have "MDN" here (I think we should keep sitename)
There was a problem hiding this comment.
Yes, sorry: I'm not suggesting we remove the site name nor description, just change references of "MDN Web Docs" to "MDN" in these places, as we appear to have dropped the former from our branding
@caugner Yes I agree here - let's make it look ok now and not have to do a follow up |
| "og:image:height": "1024", | ||
| "og:image:width": "1024", | ||
| "og:image:alt": | ||
| "The MDN Web Docs logo, featuring a blue accent color, displayed on a solid black background.", |
There was a problem hiding this comment.
Shall we improve the alt text? (cc @LeoMcA)
| "The MDN Web Docs logo, featuring a blue accent color, displayed on a solid black background.", | |
| "MDN logo on a near-black background, featuring a light-blue, stylized 'M' made of two alternating slashes and vertical bars, white 'mdn' lettering, and a light-blue underscore.", |
3 participants
Description
Updates the
twitter:cardmeta value fromsummary_large_imagetosummary.Motivation
Avoid the image from being shown unnecessarily large in link previews.
Additional details
Related issues and pull requests
Fixes #960.