Skip to content

ci(pr-review-companion): support fork PRs #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caugner wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci(pr-review-companion): support fork PRs #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3184229
ci(pr-review-companion): extract pr-build workflow
caugner Jan 21, 2026
3b0740a
ci(pr-review-companion): identify PR via GitHub API
caugner Jan 21, 2026
72bd4fe
ci(pr-build): run on fork PRs
caugner Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:
description: "Name of the build artifact to download"
required: true
type: string
build-workflow-run-id:
description: "ID of the workflow run that created the artifact"
type: number
required: false
outputs:
url:
description: "Deployment URL"
Expand All @@ -24,6 +28,8 @@ permissions:
contents: read
# Authenticate with GCP.
id-token: write
# Download artifact from workflow run.
actions: read

concurrency:
group: ci-${{ github.workflow }}-${{ inputs.prefix }}
Expand Down Expand Up @@ -51,6 +57,8 @@ jobs:
with:
name: ${{ inputs.build-artifact-name }}
path: ${{ env.BUILD_OUT_ROOT }}
github-token: ${{ inputs.build-workflow-run-id && github.token || '' }}
run-id: ${{ inputs.build-workflow-run-id || '' }}

- name: Authenticate with GCP
uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3.0.0
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: PR Build

on:
pull_request:
branches:
- main

permissions:
contents: read

jobs:
build:
if: github.repository_owner == 'mdn' && github.event.pull_request.user.login != 'dependabot[bot]'
uses: ./.github/workflows/_build.yml
secrets: inherit
with:
partial: true
42 changes: 26 additions & 16 deletions .github/workflows/pr-review-companion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,47 @@
name: PR Review Companion

on:
pull_request:
branches:
- main
workflow_run:
workflows: ["PR Build"]
types:
- completed

permissions:
contents: read
# Authenticate with GCP (same as _deploy.yml).
id-token: write
# Post comment in pull request.
pull-requests: write
# Download artifacts from triggering workflow.
actions: read

jobs:
build:
if: github.repository_owner == 'mdn' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
uses: ./.github/workflows/_build.yml
secrets: inherit
with:
partial: true
identify-pr:
if: github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
outputs:
pr-number: ${{ steps.identify-pr.outputs.number }}
steps:
- name: Identify PR
id: identify-pr
run: |
PR_NUMBER=$(gh api repos/${{ github.repository }}/commits/${{ github.event.workflow_run.head_sha }}/pulls --jq '.[0].number')
echo "number=$PR_NUMBER" >> $GITHUB_OUTPUT
env:
GITHUB_TOKEN: ${{ github.token }}
Comment on lines +25 to +31
Copy link
Contributor Author

@caugner caugner Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works as expected, I will also use this approach in the content repo, where we currently rely on a NR file included in the artifact.


deploy:
needs: build
if: github.repository_owner == 'mdn' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
needs: identify-pr
uses: ./.github/workflows/_deploy.yml
secrets: inherit
with:
cancel-in-progress: true
prefix: fred-pr${{ github.event.pull_request.number }}
build-artifact-name: ${{ needs.build.outputs.artifact-name }}
prefix: fred-pr${{ needs.identify-pr.outputs.pr-number }}
build-artifact-name: build-output
build-workflow-run-id: ${{ github.event.workflow_run.id }}

comment:
needs: deploy
needs: [identify-pr, deploy]
runs-on: ubuntu-latest
steps:
- name: Comment in PR
Expand All @@ -51,6 +61,6 @@ jobs:
gh pr comment "$PR_NUMBER" --repo "${{ github.repository }}" --body "$BODY"
fi
env:
BODY: "${{ github.sha }} was deployed to: ${{ needs.deploy.outputs.url }}"
PR_NUMBER: ${{ github.event.pull_request.number }}
BODY: "${{ github.event.workflow_run.head_sha }} was deployed to: ${{ needs.deploy.outputs.url }}"
PR_NUMBER: ${{ needs.identify-pr.outputs.pr-number }}
GITHUB_TOKEN: ${{ github.token }}
Loading