Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Merge the fillet intersection method into the rest of DVGeoMulti. This method allows for individual parameterization of two components (e.g. wing and fuselage) connected by a fillet. The fillet is not parameterized, it follows the other two components using inverse distance warping.
These changes involve some restructuring of existing DVGeoMulti code to take advantage of the shared methods between the original intersection method and this one. This PR will also add a test to the pyGeo tests.
I also made a change to pyGeo's FFD writing that lets you turn off writing the embedded volume so the output file has one less zone and it's easier to view a bunch in tecplot.
I'll add a tutorial to MACH-Aero to document this method once the journal paper is published.
Expected time until merged
No rush
Type of change
Testing
I'm adding my 2D test case as a test for this new code, these new tests should run successfully.
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable