remove importing discover from bleak, as it is no longer there in newer versions#24
Open
maraujop wants to merge 1 commit into
Open
remove importing discover from bleak, as it is no longer there in newer versions#24maraujop wants to merge 1 commit into
maraujop wants to merge 1 commit into
Conversation
bleak no longer exposes discover, and it's not being used anyway
afonsojramos
approved these changes
Aug 25, 2025
|
@mduran80 can you review this PR please? Maybe bumping the version as well |
Owner
|
Yeah, I will have a look at it.. it's just i am too busy these days. Thank
you for your contribution
…On Mon, 25 Aug 2025 at 11:10, Afonso Jorge Ramos ***@***.***> wrote:
*afonsojramos* left a comment (mduran80/pymadoka#24)
<#24 (comment)>
@mduran80 <https://github.com/mduran80> can you review this PR please?
Maybe bumping the version as well
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFK3CT6COQL4NCSNFXDKGE33PLHKHAVCNFSM6AAAAACDOATU26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJZGQ2TOMBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
works fine thx 👍 |
|
@mduran80 this will solve mduran80/daikin_madoka#62, which at the moment requires that we apply the changes in these PR to these files manually. |
|
Can anyone make a step by step to fix the issue? |
|
@mduran80 Please merge |
|
#29 contains this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
bleak no longer exposes discover, and it's not being used anyway, this is stopping daiking madoka from being able to be installed in recent HA versions.
Thanks