fix: functionality gaps (#97, #96, #109, #103, #84)#117
Merged
Conversation
Adds the draft assign test to action-sheets.spec.ts — exercises the two-step assign flow (select repo → confirm) and verifies that after assignment the new issue title appears on the index page, confirming the issues cache is invalidated on assignment.
Use a ref to track pullDistance in handleTouchEnd so the callback doesn't recreate on every pixel of movement. Also add overscroll-behavior-y: contain to prevent native pull-to-refresh from fighting with the custom implementation.
- Add console.warn to cache invalidation catch in assignDraftAction - Check refreshAction result in PullToRefreshWrapper, warn on failure - Add catch block in usePullToRefresh to prevent unhandled rejections - Log error in CreateDraftSheet catch for debuggability - Restore cacheStale signal from revalidateSafely in refreshAction
This was referenced Apr 18, 2026
Keep our assign-draft test additions (constants, seed line, test block) alongside the base file that was merged from the fix/close-issue-navigate-home branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes five UX gaps in the web dashboard and adds pull-to-refresh:
overscroll-behavior-y: containChanges
usePullToRefreshhook +PullToRefreshWrappercomponentrefreshActionserver action (clears all SQLite cache + revalidates)Test plan
pnpm turbo typecheckpasses (verified, 0 errors)pnpm turbo buildpasses (verified, all routes build)/?section=unassignedpnpm --filter @issuectl/web test:e2e— all tests pass including new assign testCloses #97, #96, #109, #103, #84