fix: resolve ghostty app path dynamically for reliable launch#119
Merged
fix: resolve ghostty app path dynamically for reliable launch#119
Conversation
macOS `open` doesn't forward the `-e` flag correctly to Ghostty, causing the shell path to be typed as text into the default session instead of executing as a new process. Use the `ghostty` binary directly which handles `-e` correctly.
Tests expected the old open -na args array layout. Updated indices to match the new ghostty CLI binary invocation.
The direct ghostty CLI binary blocks until the window closes, causing a 10s timeout on every launch. Reverted to open -na (fire-and-forget) but now resolves the .app bundle path dynamically instead of hardcoding "Ghostty.app". The CLI binary is still used for --version checks during verify().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Applications/Ghostty.app/Contents/MacOS/ghostty(closes Ghostty launcher: -e flag not working correctly via open -na on macOS #29)open -na <resolved-app-path>for launch (fire-and-forget), keeping the CLI binary for--versionchecks duringverify()ghostty -einvocation blocks until the window closes, which would timeout after 10s —open -nareturns immediately after delivering the launch eventTest plan
pnpm turbo typecheckpassespnpm turbo test— 398 tests pass (including updated ghostty.test.ts)buildGhosttyArgsproduces["-na", appPath, "--args", "--title=...", "-e", ...]resolveGhostty()returns bothbinaryandappPath