fix: Safari PWA installation — Apple meta tags and icon (#126)#140
Merged
fix: Safari PWA installation — Apple meta tags and icon (#126)#140
Conversation
#126) Safari ignores SVG icons for Add to Home Screen. Adds a 180x180 PNG apple-touch-icon generated from the existing icon.svg, the metadata.icons.apple link in layout.tsx, and the PNG entry in manifest.json. E2E test updated to assert both the manifest icon count and Apple meta tag presence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.icons.appletolayout.tsxso Next.js emits the<link rel="apple-touch-icon">tag Safari requires for Add to Home Screenapple-touch-icon.pngfrom the existingicon.svg— Safari ignores SVG icons entirelymanifest.jsonwith"purpose": "any maskable"so Android/Chrome can also use it for adaptive icon maskingpwa-offline.spec.tswith assertions for the new manifest icon count and Apple meta tag presenceCloses #126
Test plan
pnpm turbo typecheck)pwa-offline.spec.tsmanifest test asserts 2 icons (SVG + PNG)apple-mobile-web-app-capableandapple-touch-icon