fix: data freshness bugs (#128, #129, #131, #135)#144
Merged
Conversation
…ness - DetailTopBar: add document.referrer check to prevent router.back() from navigating users out of the app when they arrived from an external link (#129) - CommentComposer: surface cacheStale hint when server-side revalidation fails (#135) - E2E: replace silent if-guard with explicit test.skip, add section param assertion, add issue cleanup in afterAll
- CommentComposer: use showToast instead of setError for cacheStale hint so a successful comment post doesn't look like an error - E2E: simplify waitForServer to async while loop
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
router.refresh()after successful comment post so it appears immediately without manual page reload (When leaving a comment on an issue, when you click the comment button to save it, it does not show up locally. The screen is refreshed and the comment does not appear. It's clearly written to GitHub because if you back out of the issue, switch around from #135, When creating an issue, if you leave a comment, it disappears from the screen showing the issue after it's created, but then if you return and refresh on the index page and re-enter the issue, you can see it there. #131). SurfacecacheStalehint via toast when server-side revalidation fails."/"in addition to"/${owner}/${repo}"so newly created issues appear on the dashboard (When creating a new issue and returning to the index page, I have to pull to refresh to see it, but it should be there already. #128)router.back()+document.referrerguard to preserve filter query params on back-navigation without navigating users out of the app (When looking at a repo's issue, when you return to the index page, it looks like the filters are cleared. This shouldn't be happening. #129)data-freshness.spec.tscovering all three fixes with proper cleanup and explicit skip behaviorTest plan
/) after navigating back/, not out of the apppnpm turbo typecheckpassespnpm turbo testpasses (347 core + 60 web)