Merged
Conversation
bedec71 to
5e9fb15
Compare
Base automatically changed from
chrisvxd/remove-markup-containers
to
master
September 15, 2020 15:08
This was referenced Sep 15, 2020
5e9fb15 to
715f562
Compare
monospaced
reviewed
Sep 15, 2020
Member
monospaced
left a comment
There was a problem hiding this comment.
Problem with this: innerHTML !== children
export default () => (
<Tabs>
<Tab label="Food 1">Sausages</Tab>
<Tab label="Food 2">Bacon</Tab>
</Tabs>
);<div class="tabs">
<div class="tabs-buttons">
<button>Food 1</button>
<button>Food 2</button>
</div>
<div class="tabs-content">
<div class="tab">
Sausages
</div>
<div class="tab">
Bacon
</div>
</div>
</div>715f562 to
9b0f36e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
rehydrateChildrento work with containerises approach defined in #3. I've tried to drop any special terminology.What?
It works the same as before, but as convention suggest using own selectors instead of
data-rehydratable-childrenand referring to method asrehydrate, as it's just a prebaked version of the mainrehydratemethod.Breaking changes
rehydrateChildrenis no longer exported from the librehydrateChildrenis no longer provided to rehydrators. Usechildreninstead.Update 15/09 - adjusted to reflect that this is actually mostly retaining existing API, but fixing it to align with #3.