Skip to content

CV2-6657: AWS digram#2424

Merged
melsawy merged 4 commits into
developfrom
aws-architecture-diagram
Apr 28, 2026
Merged

CV2-6657: AWS digram#2424
melsawy merged 4 commits into
developfrom
aws-architecture-diagram

Conversation

@melsawy
Copy link
Copy Markdown
Contributor

@melsawy melsawy commented Apr 23, 2026

Description

AWS digram

References: CV2-6657

How to test?

Please describe how to test the changes (manually and/or automatically).

Checklist

  • I have performed a self-review of my code and ensured that it is safe and runnable, that code coverage has not decreased, and that there are no new Code Climate issues. I have also followed Meedan's internal coding guidelines.

@melsawy melsawy marked this pull request as ready for review April 27, 2026 13:15
Copy link
Copy Markdown
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sawy, questions:

  • What's check-web-bg?
  • We agreed to prepend the database names with the service names (RDS (PostgreSQL), Elasticache (Redis), OpenSearch (ElasticSearch))
  • Typos: "Amaon S3" / "mean-token"
  • Missing: SES (email delivery)
  • I would skip "Live" from the ECS title, since that whole architecture duplicates for QA and live
  • Presto is missing paraphrase-multilingual

@melsawy melsawy requested a review from caiosba April 28, 2026 06:24
Copy link
Copy Markdown
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sawy, it was still missing some things, but I pushed them.

@melsawy
Copy link
Copy Markdown
Contributor Author

melsawy commented Apr 28, 2026

Sawy, it was still missing some things, but I pushed them.

Thanks Caio

@melsawy melsawy merged commit 9c644a9 into develop Apr 28, 2026
9 of 10 checks passed
@melsawy melsawy deleted the aws-architecture-diagram branch April 28, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants