Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While functional, the Janode SIP plugin is a bit behind in terms of features actually available in the Janus SIP plugin. This PR adds a few missing functionality, namely:
This still leaves a few things out, like SUBSCRIBE/NOTIFY or call transfers, as those may require some minor changes to the Janus plugin itself due to the way transactions are currently correlated there (which makes it hard for Janode to know what response is for which request at the moment). I'll probably work on those in a separate and dedicated effort once this PR is merged, as those features are connected to each other anyway (you need SUBSCRIBE/NOTIFY to use REFER properly).