Fix proportion estimation for NA values#31
Open
yoda-vid wants to merge 2 commits intomeichendong:masterfrom
Open
Fix proportion estimation for NA values#31yoda-vid wants to merge 2 commits intomeichendong:masterfrom
yoda-vid wants to merge 2 commits intomeichendong:masterfrom
Conversation
Skip NA common genes from the bulk sample by recording indices where NA common genes are found and removing the corresponding column names from the output.
Only remove indices if they exist, which avoids attempting to index by NULL and removing all `yobs` values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your deconvolution software. I encountered an error during proportion estimation where some
NAcommon genes would be found for some bulk cells. Here is an example stacktrace:I was able to work around it by skipping these cells and recording their indices to remove the barcodes. I am not sure if this is the best solution though and wanted to share it here in case it is useful or if there is a better approach.
Might be related to #17, #18.