Separate transport and status availability - #2
Draft
mel9320107 wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Previously, any recognised protocol frame refreshed the integration's single availability flag. Bus-management or configuration traffic could therefore make an old
SpaStateappear current after a reconnect or after regular status frames stopped arriving.Validation
python -m unittest -q tests.test_client_availability— 3 tests passed.python -m compileall -q custom_components/spa_pool tests— passed.mainand changes only the six integration files plus the focused test file.Hardware testing requested
Please install this draft branch in Home Assistant and verify normal entity availability, command behaviour, and recovery after temporarily interrupting spa status traffic or the TCP connection.