Skip to content

Handle unassigned output_path in API cleanup #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melroyanthony wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle unassigned output_path in API cleanup #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e16e1c7
Handle unassigned output_path in API cleanup
melroyanthony Jun 5, 2025
279dcbe
Update api/main.py
melroyanthony Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions api/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ async def generate_discharge_note(

# Create a temp file to store the consultation data
temp_file = UPLOAD_DIR / f"consultation_{id(request)}.json"
output_path: Path | None = None
try:
with temp_file.open("w") as f:
json.dump(request.consultation_data, f)
Expand All @@ -107,8 +108,12 @@ async def generate_discharge_note(
# Clean up temporary files
if temp_file.exists():
temp_file.unlink()
if output_path.exists():
output_path.unlink()
# output_path might remain None if discharge_generator.process_file fails
if output_path:
if output_path.exists():
output_path.unlink()
else:
logger.info(f"Skipping cleanup for output_path as it does not exist: {output_path}")

except Exception as e:
logger.error(f"❌ Error generating discharge note: {e}")
Expand Down
48 changes: 23 additions & 25 deletions tests/unit/api/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,31 +117,29 @@ def test_generate_endpoint_error(
mock_generator.process_file.side_effect = ValueError("Test error")
mock_upload_dir.__truediv__.return_value = Path("test_file.json")

# Mock Path.exists and Path.unlink to avoid UnboundLocalError for output_path
with patch("pathlib.Path.exists", return_value=False): # Avoid trying to unlink files
# Execute
response = test_client.post(
"/generate",
json={
"consultation_data": {
"patient": {
"name": "Max",
"species": "Dog",
"breed": "Golden Retriever",
"gender": "Male",
"neutered": True,
"date_of_birth": "2018-05-10",
"weight": "32 kg",
},
"consultation": {
"date": "2023-07-15",
"time": "10:30",
"reason": "Vomiting",
"type": "Outpatient",
},
}
},
)
# Execute without patching Path.exists to ensure cleanup handles None output_path
response = test_client.post(
"/generate",
json={
"consultation_data": {
"patient": {
"name": "Max",
"species": "Dog",
"breed": "Golden Retriever",
"gender": "Male",
"neutered": True,
"date_of_birth": "2018-05-10",
"weight": "32 kg",
},
"consultation": {
"date": "2023-07-15",
"time": "10:30",
"reason": "Vomiting",
"type": "Outpatient",
},
}
},
)

# Assert
assert response.status_code == 500
Expand Down