Open
Conversation
This reverts commit dde4b12.
This reverts commit 16e9fc9.
This reverts commit faaa13c.
# Conflicts: # lib/membrane_rtmp_plugin/rtmp/header.ex
ClientHandler never returned {:stop, ...} in any code path, causing
leaked processes. This is especially problematic with TCP health checks
(e.g. from NLB) that connect and immediately disconnect every 30s,
each leaving a zombie GenServer behind.
Contributor
|
As far as I can see the actual change in this PR is stopping the client handler GenServer's, let's rebase the PR after #118 is merged and it will be fine to merge this one too 👍 |
The client_timeout handler always called {:stop, :normal, state}
regardless of whether the client had successfully published. This
caused all RTMP connections to be terminated after 5 seconds, even
when data was actively flowing.
Move the stop into the not-published branch so active connections
are left alone when the timeout fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a client does TCP health-checks on a listener based on this library, we leak ClientHandler processes at each call. This addresses that by closing the hander. In is built on top of #118