Link colours - #3
Open
Seb35 wants to merge 2 commits into
Open
Conversation
If the Memento date is before the creation of a page or a template, the links will be red.
Contributor
|
I'm very intrigued by this functionality, and would like to understand the reasoning behind it. Is the idea that nonexistent pages (by default red links) will be red rather than blue, seeing as they hadn't been created at the time of the Memento? |
Author
|
Yes, it’s this reasoning. For example, on a page "Example":
With this patch:
This patch/feature requires more DB accesses (check the existence of each pages), so perhaps a tuning parameter could/should be added to let sysadmins control the load. (The $skip feature doesn’t need additional resources, probably even a bit less.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the feature about the colour of the links – red or blue – at the time of the Memento.
It has been quickly tested on one example (so more testing is probably needed), and more work is needed for the details (see @fixme: green and blue italics colours, and deleted-then-recreated links, and check the parser cache status about the link colours).
I will understand if you prefer not to merge now, to check the parser cache status and wait more testing. In any case, I will try to continue to work on this feature. As a side note, I plan to incoporate the work I did on my extension BackwardsTimeTravel into Memento https://www.mediawiki.org/wiki/Extension:BackwardsTimeTravel#Deprecation.