Skip to content

Fix broken public api malt reader (issue #156) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
svalat merged 3 commits into from
Jan 21, 2026
Merged

Fix broken public api malt reader (issue #156) #157

svalat merged 3 commits into from
Jan 21, 2026

Conversation

@svalat
Copy link
Member

@svalat svalat commented Jan 21, 2026

  • Fix the broken API which does not compile in C and has linkage error.
  • Fix implementation of getBinaryAddressesFlatProfile and add getBinaryAddressesFlatProfileAll

svalat added 2 commits January 21, 2026 17:00
@svalat
[reader] Fix the public API and usage of malt_reader_json_get_binary_…
70a18fa 
…addresses_profile (still need to add offsets in result) (working on memtt#156)
@svalat
[reader] Fix output of get binary functions by adding the offset and …
19cc4a5 
…use binary inside. Also keep the offset all the time. (working on memtt#156)
@svalat svalat added this to the next milestone Jan 21, 2026
@svalat svalat self-assigned this Jan 21, 2026
@svalat svalat added the bug Something isn't working label Jan 21, 2026
@svalat svalat changed the title Fix borken public api malt reader (issue #156) Fix broken public api malt reader (issue #156) Jan 21, 2026
@svalat svalat merged commit ca07ffe into memtt:master Jan 21, 2026
1 check passed
@svalat svalat deleted the issue/156-borken-public-api-malt-reader branch January 21, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@svalat svalat

Labels

bug Something isn't working

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

1 participant

@svalat