[PAG-2696] Add prompt attribute to widget xml#138
Draft
MendixDanijel wants to merge 2 commits intomendix:masterfrom
Draft
[PAG-2696] Add prompt attribute to widget xml#138MendixDanijel wants to merge 2 commits intomendix:masterfrom
MendixDanijel wants to merge 2 commits intomendix:masterfrom
Conversation
weirdwater
requested changes
Aug 28, 2025
Collaborator
There was a problem hiding this comment.
Hi @MendixDanijel, thanks for the PR. In my opinion the generated widget should act as a minimal viable widget that can be used immediately in Studio Pro and can be easily adapted to your usecase.
In this case I think the generated prompts act too much as placeholders and should serve more as example prompts. The developer can easily remove them or adapt them to their usecase as needed. Generally after generating the widget the first step is to edit the xml file anyway, so this is a reasonable expectation.
My suggestions would be to:
- Remove the generation prompt. I think it is okay to always generate the example prompts. There are already a lot of questions and the elements are easily removed if not needed.
- Rewrite the prompt elements (including that for the widget) to make sense in the context of the example widgets. Currently they resemble placeholders rather than examples. This is an opportunity to show what kind of prompts we expect and how the prompt element differs from the caption and or description elements.
f3c301c to
05e91f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Adding prompt attribute to xml file and to widget generator questions.
Relevant changes
What should be covered while testing?
Generating a widget using the bin.js script.