Update GitHub Actions to current versions - #18
Merged
Conversation
- Upgrade actions/checkout from v2 to v4 - Upgrade release-drafter/release-drafter from v5 to v6 - Upgrade runner OS from ubuntu-20.04 to ubuntu-24.04 - Upgrade ec2-metadata-mock from v1.8.1 to v1.13.0 - Upgrade bats-version from 1.2.1 to 1.11.1 - Remove manual shellcheck apt-get install (pre-installed on runner) - Add explicit permissions blocks for release-drafter and shell-docs - Add dependabot.yml for automated GitHub Actions version updates
github-actions
Bot
added
the
documentation
The test files start ec2-metadata-mock in setup_file() but never kill it in teardown_file(). When running multiple test files sequentially, subsequent files fail to bind port 1338. Kill the mock process between test file runs to avoid port conflicts. Also replace mig4/setup-bats (stuck on node12) with direct bats-core install from source.
Bats-core 1.7+ waits for background processes spawned in setup_file() to exit before completing a test file. The test suite starts ec2-metadata-mock in setup_file() without killing it in teardown_file(), causing bats to hang indefinitely. Pin to v1.2.1 (original working version) until test files are updated. Also replaces mig4/setup-bats (node12, unmaintained) with direct install from bats-core source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutfrom v2 to v4 (all workflows)release-drafter/release-drafterfrom v5 to v6ubuntu-20.04toubuntu-24.04(all workflows)ec2-metadata-mockfrom v1.8.1 to v1.13.0bats-versionfrom 1.2.1 to 1.11.1apt-get install shellcheck(pre-installed on ubuntu-24.04 runners)permissionsblocks for release-drafter and shell-docs workflows.github/dependabot.ymlfor automated GitHub Actions version updates going forwardTest plan