feat(config)!: remove COI_LIMIT_* env overrides — no env-var config layer at all#538
Merged
Merged
Conversation
…ayer at all The seven COI_LIMIT_* vars duplicated [limits.*] config and silently outranked explicit config files. Limits are config/profile-only now; the configuration hierarchy is exactly defaults -> user config ($COI_CONFIG) -> project config -> profile, nothing else. loadFromEnv is gone entirely. Operational env vars ($COI_CONFIG, test/debug toggles) are unaffected — they select or diagnose, they don't configure. The env-var limits tests were converted into removal assertions: setting COI_LIMIT_* must apply nothing, and config values must win when both are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the 0.10 configuration principle: after the flags (#532, #536) and the legacy
CLAUDE_ON_INCUS_*vars (#537), this removes the last env-var config layer.The seven
COI_LIMIT_*vars (CPU,CPU_ALLOWANCE,MEMORY,MEMORY_SWAP,DISK_READ,DISK_WRITE,DURATION) duplicated the[limits.*]config sections and silently outranked explicit config files. Limits are config/profile-only now.The configuration hierarchy is exactly: defaults → user config (
$COI_CONFIG) → project config → profile — nothing else.loadFromEnvis deleted entirely.Unaffected (operational, not config):
$COI_CONFIG(selects which config file), test infrastructure (COI_USE_DUMMY,COI_CONTAINER_PREFIX), debug toggles (COI_NFT_DEBUG,COI_BUILD_SCRIPT_FROM_DISK).Tests: the three env-var limits tests became removal assertions —
COI_LIMIT_*set must apply nothing, and config values must win when both are present. README precedence section updated.Gates: go build/vet/test, golangci-lint v2.12.2 (0 issues), gofmt, ruff — green.