remove prodigal driver and multithread class#2536
Open
FlorianTrigodet wants to merge 1 commit intomasterfrom
Open
remove prodigal driver and multithread class#2536FlorianTrigodet wants to merge 1 commit intomasterfrom
FlorianTrigodet wants to merge 1 commit intomasterfrom
Conversation
|
I woul remove the use of prodigal as there is a long standing bug that still unpatched in “plain” prodigal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still have a prodigal driver and a class in threadingops.py and the only place where prodigal is imported is in genecalling.py but no user can request the use of Prodigal from the command line interface.
The only reason we could keep it is if (1) we plan to make it available to the user, or (2) when someone uses anvi'o classes/function outside of the command lines.
@meren, let me know your thoughts. If we should keep it, just delete the branch.