Harden settlement XDR intent validation - #291
Merged
mergekeeper[bot] merged 3 commits intoAug 31, 2026
Merged
Conversation
Bind optional persisted source sequences and explicit fee ceilings into the shared signed-envelope validator so wallet-signed payments cannot alter replay sequencing or fee exposure. Closes mergepay#190 Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@princewille277-dotcom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
MergeKeeper review Scope: in scope for linked issue The PR successfully hardens Stellar settlement XDR validation by binding optional source sequence and explicit fee ceilings, complete with tests. Reviewed commit: |
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
Contributor
|
Merged Merged with |
Bogunrot
pushed a commit
to Bogunrot/mergepay-api
that referenced
this pull request
Sep 1, 2026
Bind optional persisted source sequences and explicit fee ceilings into the shared signed-envelope validator so wallet-signed payments cannot alter replay sequencing or fee exposure. Closes mergepay#190 Generated with Codebuff 🤖 Co-authored-by: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind optional persisted source sequences and explicit fee ceilings into the shared signed-envelope validator so wallet-signed payments cannot alter replay sequencing or fee exposure.
Closes #190
What does this PR do?
Checklist
npm run buildpassesnpm testpasses (offline — DB/network mocked)mergepay-webRelated issues