feat(webhooks): dispatch settlement outcome events - #312
Conversation
|
@thelight08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes The PR emits settlement events via emitEvent instead of calling the required webhook service directly, and uses eventType 'settlement.completed' instead of 'settlement.confirmed'.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR emits events via a generic event bus instead of implementing and calling the required webhook service and worker dispatch as specified in the issue.
src/services/settlement-reconciliation.ts:14: Issue requires implementingsrc/services/webhook.tsand dispatching webhooks from the background settlement worker, but this PR usesemitEventinstead of calling a webhook dispatch service.
Reviewed commit: bf33037480a64587579cc3802a37727e59f9f141.
There was a problem hiding this comment.
Needs changes
The PR emits settlement events via a generic event emitter instead of implementing the required webhook notification service (src/services/webhook.ts), signing mechanism (X-Mergepay-Signature), and worker integration specified in the issue.
src/services/settlement-reconciliation.ts:14: The issue requires implementingsrc/services/webhook.tsto construct, sign, and send HTTP POST webhook payloads directly, but the PR usesemitEventinstead.
Reviewed commit: 36c6a689480ddc875d0794e733cb34d533e2db54.
There was a problem hiding this comment.
Needs changes
The PR emits settlement events via emitEvent instead of calling the required webhook service directly, and uses eventType 'settlement.completed' instead of 'settlement.confirmed'.
src/services/settlement-reconciliation.ts:184: Issue requires implementing webhook dispatch directly from the background settlement worker using the webhook service (src/services/webhook.ts), but uses emitEvent instead.src/services/settlement-reconciliation.ts:216: Event type 'settlement.completed' does not match the issue requirement 'settlement.confirmed'.
Reviewed commit: ec28853571ee2fa1b466d4b8fac383bc17c85d57.
|
@Cjay-Cyber-2 The webhook fix is pushed and ready for review. Reconciliation now emits group-scoped settlement.completed/settlement.failed events to the signed asynchronous dispatcher. Closes #280. |
|
MergeKeeper review Scope: in scope for linked issue Webhook dispatching and event integration for settlement outcomes are correctly implemented according to issue #280 requirements. Reviewed commit: |
c5b33b8 to
6a17dd0
Compare
6a17dd0 to
9f7cf73
Compare
Closes #280
Emits settlement completion and failure outcomes from reconciliation so the existing signed webhook dispatcher can notify configured subscribers without blocking worker execution.