feat(audit): expose group audit history - #315
Conversation
|
@thelight08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes The PR implements audit log endpoints and actions, but lacks required unit and integration tests for route access authorization and audit log creation.
Reviewed commit: |
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
There was a problem hiding this comment.
Needs changes
The PR exposes the required plural endpoint but fails to implement structured security audit logging for administrative group updates, central audit log service, and tests.
src/routes/audit-log.ts: Missing implementation of administrative audit log creation within group update actions as required by issue #277.- Review finding: Missing required unit and integration tests verifying audit log creation and route access authorization.
Reviewed commit: c18e4c4e25eab5c043e94844a2a2391552e260e4.
|
@Cjay-Cyber-2 The plural authenticated audit-log endpoint is pushed and ready for review; the existing singular route remains compatible. Closes #277. |
|
MergeKeeper review Scope: in scope for linked issue The pull request correctly implements the requested administrative audit logging service updates, endpoints, and transactional audit records according to issue requirements. Reviewed commit: |
55da565 to
e2b1c52
Compare
|
Needs review Linked to The pull request modifies and removes test coverage, routes, and services that were not requested or conflict with the requirements specified in issue #277. Reviewed commit: |
There was a problem hiding this comment.
Needs changes
The PR implements administrative audit logging actions and updates routes, but misses the requested GET /groups/:id/audit-logs endpoint and associated tests.
src/routes/groups.ts: Missing implementation of the required GET /groups/:id/audit-logs endpoint to query paginated historical audit events restricted to group admins.
Reviewed commit: 939ae4adf8729cc29a1c9db4685ba3bd115c57e6.
c2436a6 to
ddd6195
Compare
There was a problem hiding this comment.
Needs changes
The PR implements audit log endpoints and actions, but lacks required unit and integration tests for route access authorization and audit log creation.
tests/routes/groups.test.ts: Missing required unit and integration tests verifying audit log creation and route access authorization as specified in the issue acceptance criteria.
Reviewed commit: ddd61956bfaaca764ab27de70b4fd15fa009d2eb.
4 participants
Closes #277
Adds the plural authenticated group audit-log endpoint while retaining the existing singular route for compatibility. Access remains restricted to group administrators.