Fix active-member authorization for expense payer - #473
Merged
Conversation
|
@69starman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Needs changes Authorization failures for group membership check violations must return 403 Forbidden instead of 400 Bad Request according to issue requirements.
Reviewed commit: |
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Needs changes
Authorization failures for group membership check violations must return 403 Forbidden instead of 400 Bad Request according to issue requirements.
src/routes/expenses.ts:50: Non-member check throws a 400 Bad Request error via Errors.badRequest, but the issue and acceptance criteria require returning 403 Forbidden for non-member restricted operations.
Reviewed commit: 238a494bb903be45bec17babc9afe1e135a76cce.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CLOSES #337
Checklist
npm run buildpassesnpm testpasses (offline — DB/network mocked)mergepay-webRelated issues