Revert "Implement SEP-24 callback auth, worker query indexes, unified error responses, and graceful shutdown" - #493
Merged
K1NGD4VID merged 2 commits intoSep 3, 2026
Conversation
… error r…" This reverts commit dbe792c.
main has been red since the Sep 2 merge avalanche: mangled conflict resolutions left a stray brace and undefined symbols across the worker, anchor, stellar, and treasury services, plus a duplicate Fastify route that crashed app boot for nearly every test suite. Restore the intended code (unknown-status handling, permanent anchor poll failures, typed ProviderError plumbing, audit record placement) and align two stale treasury tests with the merged service contracts. tsc is clean and all 1797 tests pass. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #375
Summary
Implements audit logging for expense creation and deletion as a security and transparency requirement. Every state-changing action is now recorded for later review.
Changes
Schema
AuditLogmodel already existed inprisma/schema.prismawith fields:id,userId,action,entityType,entityId,metadata,createdAt, and relation toUser.Expense Routes (
src/routes/expenses.ts)prisma.$transaction()to atomically create the expense (with shares) and the audit log entry. If audit log creation fails, the entire transaction rolls back.prisma.$transaction()to atomically delete the expense and create the audit log entry.Audit Log Entries Created
action: 'expense.create',entityType: 'expense',entityId: expense.id,metadata: { groupId, amount, assetCode }action: 'expense.delete',entityType: 'expense',entityId: expense.idTests (
tests/routes.test.ts)Added 3 new tests under
expense routesdescribe block:Acceptance Criteria Met
Closes #199
Closes #200
Closes #201
Closes #203