Fix CI/CD: npm workspaces lockfile, missing ESLint configs, Docker credential handling - #2
Merged
Merged
Conversation
…npm workspaces Co-authored-by: mesayanroy <169074736+mesayanroy@users.noreply.github.com>
… workspace install Co-authored-by: mesayanroy <169074736+mesayanroy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix errors in CI checks and prepare for deployment
Fix CI/CD: npm workspaces lockfile, missing ESLint configs, Docker credential handling
Mar 10, 2026
mesayanroy
marked this pull request as ready for review
March 10, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 4 failing CI checks stemmed from the repo being an npm workspaces project but the workflows expecting per-subdirectory
package-lock.jsonfiles (which don't exist), plus zero ESLint configuration anywhere. The Deploy job crashed immediately on Docker login when Hub secrets weren't configured.CI workflow (
ci.yml)defaults.run.working-directoryfrom each job; replaced with explicitworking-directory:per stepcache-dependency-pathfrombackend/package-lock.jsonetc. → rootpackage-lock.jsonnpm cinow runs from repo root (resolves the workspace lockfile); lint/typecheck/test steps still run from their workspace directoryESLint configs (all new)
backend/.eslintrc.json/cli/.eslintrc.json—@typescript-eslint/recommendedwithout typed linting (avoids tsconfig path resolution issues across src + tests)frontend/.eslintrc.json—next/core-web-vitalsonly (@typescript-eslintplugin is not in frontend deps)Deploy workflow (
deploy.yml)publish-cli: same workspace-install fix as CI (rootnpm ci, explicitworking-directory: cliper step)push-docker-images: removed invalid job-levelsecrets.*condition (GitHub Actions doesn't allowsecretscontext in jobif); replaced with a step-level credential pre-check that emits a warning and skips push steps whenDOCKER_USERNAME/DOCKER_TOKENare absent:Minor fixes
mev-detector.ts: removed unusedPublicKeyimport; exportedDEX_PROGRAMS(was assigned but never used — lint error)frontend/public/.gitkeep:Dockerfile.frontendunconditionallyCOPYs this directory; it must exist🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.