Skip to content

chore: update approve-to-run-ci (Meshery-Operator CI) workflow#768

Open
Katotodan wants to merge 3 commits into
meshery:masterfrom
Katotodan:chore/kubebuilder
Open

chore: update approve-to-run-ci (Meshery-Operator CI) workflow#768
Katotodan wants to merge 3 commits into
meshery:masterfrom
Katotodan:chore/kubebuilder

Conversation

@Katotodan
Copy link
Copy Markdown
Contributor

Description
This PR update the golangci-lint job to checkout code before setting up golang.
It set the golangci/golangci-lint-action@v9 to use one of the compatible version, I have use the latest version.
The actions/checkout@master present some security vulnerability, this PR set the action to actions/checkout@v6.
It also update the actions/setup-go@v4 to actions/setup-go@v5

This PR fixes #767

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@welcome
Copy link
Copy Markdown

welcome Bot commented May 19, 2026

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Katotodan added 2 commits May 19, 2026 22:06
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Comment thread .github/workflows/approve-to-run-ci.yml Outdated
uses: golangci/golangci-lint-action@v9
with:
version: v2.8.0
version: latest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using version: latest for golangci-lint is generally considered an anti-pattern because any new linter release can introduce new rules and unexpectedly break the CI on unrelated PRs.

In fact, this change is why the golangci-lint check is currently failing in this PR! The newer version (v2.12.2) is now flagging an unused variable here: api/v1alpha1/meshsync_types_test.go:102:4: 1 (untyped int constant) is not used (typecheck).

Could you please do two things:

  1. Pin this to a specific version (e.g., version: v2.12.2) instead of using latest.
  2. Fix the newly surfaced linting error in api/v1alpha1/meshsync_types_test.go so the checks can pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] chore: CI workflow Meshery-Operator CI

2 participants