chore: update approve-to-run-ci (Meshery-Operator CI) workflow#768
chore: update approve-to-run-ci (Meshery-Operator CI) workflow#768Katotodan wants to merge 3 commits into
Conversation
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
| uses: golangci/golangci-lint-action@v9 | ||
| with: | ||
| version: v2.8.0 | ||
| version: latest |
There was a problem hiding this comment.
Using version: latest for golangci-lint is generally considered an anti-pattern because any new linter release can introduce new rules and unexpectedly break the CI on unrelated PRs.
In fact, this change is why the golangci-lint check is currently failing in this PR! The newer version (v2.12.2) is now flagging an unused variable here: api/v1alpha1/meshsync_types_test.go:102:4: 1 (untyped int constant) is not used (typecheck).
Could you please do two things:
- Pin this to a specific version (e.g.,
version: v2.12.2) instead of usinglatest. - Fix the newly surfaced linting error in
api/v1alpha1/meshsync_types_test.goso the checks can pass.
Description
This PR update the golangci-lint job to checkout code before setting up golang.
It set the golangci/golangci-lint-action@v9 to use one of the compatible version, I have use the latest version.
The actions/checkout@master present some security vulnerability, this PR set the action to actions/checkout@v6.
It also update the actions/setup-go@v4 to actions/setup-go@v5
This PR fixes #767
Notes for Reviewers
Signed commits