Add support for sending message reactions and expose additional packet metadata#149
Open
skgsergio wants to merge 3 commits into
Open
Add support for sending message reactions and expose additional packet metadata#149skgsergio wants to merge 3 commits into
skgsergio wants to merge 3 commits into
Conversation
Author
|
I also saw this is done in #98 I could close this then 🤷🏻♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Emoji/Reaction Support: Added is_reaction parameter to send_text, send_direct_message, and broadcast_channel_message services
Message Event Metadata:
Additional info
I noticed when I was going to do the PR with the code already done that my changes cover what #126 proposes.
So, I can drop that part depending on whether we prefer the hop_limit and hop_start or just the number of hops. My two cents: I prefer to have both values and calc the hop numbers if I need it.